Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flash type when updating entreprise fees #11981

Conversation

bouaik
Copy link
Contributor

@bouaik bouaik commented Dec 25, 2023

What? Why?

What should we test?

  • Visit configuration/enterprise fees
  • Update
  • Check the flash type to be a success

I tested the rest of the application for such bugs, but didn't find any, also, can we test for the type of flash messages in system tests ?

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@drummer83 drummer83 self-assigned this Jan 6, 2024
@drummer83 drummer83 added the pr-staged-au staging.openfoodnetwork.org.au label Jan 6, 2024
@drummer83
Copy link
Contributor

Hi @bouaik,
Thanks for fixing this one!

I can confirm that after staging your PR we now see the correct success message:
image

Also as super admin user:
image

Great! 🎉
This one is ready to get merged! 🚀

Thanks again for this contribution!

@drummer83 drummer83 merged commit 1e9aaf1 into openfoodfoundation:master Jan 6, 2024
52 checks passed
@drummer83 drummer83 removed the pr-staged-au staging.openfoodnetwork.org.au label Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Incorrect mapping of flash messages on enterprise fees page
3 participants