Add keyboard shortcut to submit forms #11990
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Although enter will submit the form in many cases, it doesn't cover elements such as
textarea
.Power users of web apps would be familiar with the keyboard shortcut for submitting forms:
ctrl+enter ( or cmd+enter for macOS). Refer: https://ux.stackexchange.com/a/136590/36009
This will enable power users to submit standard forms quicker. Unfortunately I couldn't get it to work for Angular forms which are widespread, so the benefit is reduced. If anyone knows how to do that, it would be nice..
Note that the web "standard" of
accesskey
is not accepted as a solution for this, hence the need for Javascript (see https://webaim.org/techniques/keyboard/accesskey).What should we test?
Submit some forms in frontend and backend. For example:
Admin
Release notes
It's probably not worth mentioning as a user-facing change unless we can implement it for all (angular) forms.
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates