Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary require instructions #11998

Conversation

abdellani
Copy link
Member

What? Why?

unnecessary require instruction will cause raising exceptions in Rails 7.1

This is needed for #11673

What should we test?

  • Visit ... page.

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@abdellani abdellani self-assigned this Jan 3, 2024
@abdellani abdellani marked this pull request as ready for review January 3, 2024 12:08
Copy link
Collaborator

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one !

@mkllnk mkllnk added the pr-staged-au staging.openfoodnetwork.org.au label Jan 4, 2024
@mkllnk
Copy link
Member

mkllnk commented Jan 4, 2024

Staging worked.

@mkllnk mkllnk merged commit e2aeb18 into openfoodfoundation:master Jan 4, 2024
52 checks passed
@mkllnk mkllnk removed the pr-staged-au staging.openfoodnetwork.org.au label Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants