Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ToS Position Issue #12009

Conversation

chahmedejaz
Copy link
Collaborator

@chahmedejaz chahmedejaz commented Jan 4, 2024

What? Why?

Observation while addressing the issue

  • It has been noticed that the z-index values used for various elements within our application are currently set without a structured approach.
  • To enhance clarity and help us compare the expected stacking order based on their positions, I suggest we define these z-index values as meaningful variables in the variables.scss file in a separate issue.
  • It not only improves readability but also streamlines the process of understanding the stacking order concerning specific elements with each other.

Would love to hear some thoughts on it. Thanks.

What should we test?

  • Please validate the expected behavior as mentioned in the linked issue
  • Along with that please make sure when ToS is being displayed, nothing should be broken on the UI in terms of the elements' position.

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Copy link
Collaborator

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one!

@drummer83 drummer83 self-assigned this Jan 10, 2024
@drummer83 drummer83 added pr-staged-uk staging.openfoodnetwork.org.uk pr-staged-fr staging.coopcircuits.fr and removed pr-staged-uk staging.openfoodnetwork.org.uk labels Jan 10, 2024
@drummer83
Copy link
Contributor

Hi @chahmedejaz,
Thanks for fixing this! 👍

After staging I could click all links and buttons on both notifications. The problem is solved. 🎉

image

Also, I couldn't spot any other regressions, so this one is ready to go! 🚀
Merging! Thanks again!

@drummer83 drummer83 merged commit 19dd5b1 into openfoodfoundation:master Jan 10, 2024
55 of 56 checks passed
@drummer83 drummer83 removed pr-staged-uk staging.openfoodnetwork.org.uk pr-staged-fr staging.coopcircuits.fr labels Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUU] Terms of Service (ToS) can't be accepted or read when additional notification is displayed
4 participants