DRY specs with fixture_file_upload helper #12013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't use it in factories but in other places it's a nice shortcut.
mkllnk
added
the
technical changes only
rioug
approved these changes
Jan 8, 2024
| @@ -9,7 +9,7 @@ | |||
|
|
|||
| describe "uploading an image" do | |||
| let(:image) { black_logo_file } | |||
| let(:pdf) { Rack::Test::UploadedFile.new(pdf_path, 'application/pdf') } | |||
| let(:pdf) { fixture_file_upload(pdf_path, 'application/pdf') } | |||
There was a problem hiding this comment.
TIL about fixture_file_upload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
I noticed a mixture of our own file helpers and plenty of references to
Rack::Test::UploadedFilewith many repetitions of the same paths. So I removed repetitions and favouredfixture_file_uploadto simplify the code and minimise confusion about what the best practice is.What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates