Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove feature toggle for vouchers, they are always on #12014

Merged
merged 6 commits into from
Jan 9, 2024

Conversation

mkllnk
Copy link
Member

@mkllnk mkllnk commented Jan 8, 2024

What? Why?

Simplify code and make sure that all specs are run with vouchers activated as in production.

What should we test?

  • Specs only.

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

CI can then tell me if some specs still rely on it being disabled.
The Vouchers tab pushed the White Label tab further down and it was
hidden by the savebar. The CSS adjustment in this commit makes sure
that users can always see all menu items.

The automatic scrolling by Capybara fails because of the savebar but
scrolling to the bottom works.
@mkllnk mkllnk added the technical changes only These pull requests do not contain user facing changes and are grouped in release notes label Jan 8, 2024
@mkllnk mkllnk self-assigned this Jan 8, 2024
@mkllnk mkllnk marked this pull request as ready for review January 8, 2024 05:07
Copy link
Collaborator

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one !

Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@dacook dacook merged commit 47418d9 into openfoodfoundation:master Jan 9, 2024
52 checks passed
@mkllnk mkllnk deleted the voucher-on branch January 10, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical changes only These pull requests do not contain user facing changes and are grouped in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Remove voucher feature toggle
3 participants