Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump stripe from 10.3.0 to 10.5.0 #12018

Merged
merged 4 commits into from
Jan 18, 2024
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 8, 2024

Bumps stripe from 10.3.0 to 10.5.0.

Release notes

Sourced from stripe's releases.

v10.5.0

  • #1306 Update generated code
    • Add support for retrieve method on resource Tax.Registration

See the changelog for more details.

v10.5.0-beta.1

  • #1302 Update generated code for beta

See the changelog for more details.

v10.4.0

  • #1303 Update generated code
    • Add support for new resource FinancialConnections.Transaction
    • Add support for list and retrieve methods on resource Transaction
    • Add support for subscribe and unsubscribe methods on resource FinancialConnections.Account
  • #1304 Add support for updatable singleton resources

See the changelog for more details.

v10.4.0-beta.1

Updated stable APIs to the latest version

See the changelog for more details.

Changelog

Sourced from stripe's changelog.

10.5.0 - 2024-01-04

  • #1306 Update generated code
    • Add support for retrieve method on resource Tax.Registration

10.4.0 - 2023-12-22

  • #1303 Update generated code
    • Add support for new resource FinancialConnections.Transaction
    • Add support for list and retrieve methods on resource Transaction
    • Add support for subscribe and unsubscribe methods on resource FinancialConnections.Account
  • #1304 Add support for updatable singleton resources
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies ruby Pull requests that update Ruby code labels Jan 8, 2024
@dacook dacook self-assigned this Jan 10, 2024
@dacook dacook force-pushed the dependabot/bundler/stripe-10.5.0 branch from bfabf30 to c1b5122 Compare January 11, 2024 23:33
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 15, 2024

A newer version of stripe exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

dependabot bot and others added 4 commits January 17, 2024 15:14
Bumps [stripe](https://github.com/stripe/stripe-ruby) from 10.3.0 to 10.5.0.
- [Release notes](https://github.com/stripe/stripe-ruby/releases)
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md)
- [Commits](stripe/stripe-ruby@v10.3.0...v10.5.0)

---
updated-dependencies:
- dependency-name: stripe
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
We really need to update our documentation more, but this is better than nothing.
Why mask the actual exception with a made-up one? The name did convey a bit more context, but Bugsnag tracks the context anyway. It would be more helpful to record the details of the error.

Just in case, I checked if there were any recorded instances of StripeDeauthorizeFailure. I couldn't find any in Bugsnag (last 3 months) for AU, Germany, Katuma, NZ, Norway, UK, USA. Also no mention in GitHub issues.
Note that stripe_account_spec.rb:51 requires a special client_id
@dacook dacook force-pushed the dependabot/bundler/stripe-10.5.0 branch from 37fa49a to f348cbc Compare January 17, 2024 04:16
@dacook
Copy link
Member

dacook commented Jan 17, 2024

The fix was to use a special STRIPE_CLIENT_ID, which is not documented. I will discuss in #dev to ensure it's documented or set up for next time.

Note that there is now also a newer version of the gem. Given that we're already skipping a version, I suggest we merge this one before doing the next upgrade.

Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find.

  • Tests run locally.
  • Recording live tests runs locally.

I'm missing the client id. I wasn't able to use the old one from this commit. So someone has to add new credentials to Bitwarden, I think. When doing a simple copy-and-paste, we may as well have the client id in there and filter it from the output.

Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got the client id now and it works.

@mkllnk mkllnk merged commit 08ca852 into master Jan 18, 2024
52 checks passed
@mkllnk mkllnk deleted the dependabot/bundler/stripe-10.5.0 branch January 18, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants