Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Connected Apps only to enterprise managers #12030

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

mkllnk
Copy link
Member

@mkllnk mkllnk commented Jan 11, 2024

What? Why?

Super-admins also saw that tab but connecting an app doesn't work unless you are a manager of that enterprise.

What should we test?

  • CI test coverage is good enough.

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

There was no spec despite lots of logic. And I want to add more logic.
Super-admins also saw that tab but connecting an app doesn't work unless
you are a manager of that enterprise.
@mkllnk mkllnk self-assigned this Jan 11, 2024
@mkllnk mkllnk added the technical changes only These pull requests do not contain user facing changes and are grouped in release notes label Jan 11, 2024
@mkllnk mkllnk marked this pull request as ready for review January 11, 2024 01:32
Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

Copy link
Collaborator

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one !

@rioug rioug merged commit 64043b8 into openfoodfoundation:master Jan 15, 2024
54 checks passed
@mkllnk mkllnk deleted the connected-apps-visibility branch February 8, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical changes only These pull requests do not contain user facing changes and are grouped in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants