Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes default selection for User facing changes #12035

Conversation

filipefurtad0
Copy link
Contributor

@filipefurtad0 filipefurtad0 commented Jan 11, 2024

What? Why?

Removes default selection for User facing changes (Changelog Category), from the GH pull request template.

As discussed here.

What should we test?

  • green build.
  • creating a PR should have no selected option for the Changelog Category (changes should only take effect after merging).

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@filipefurtad0 filipefurtad0 added the technical changes only These pull requests do not contain user facing changes and are grouped in release notes label Jan 11, 2024
@RachL
Copy link
Contributor

RachL commented Jan 11, 2024

thanks @filipefurtad0 🤗

Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't apply a label to the PR, it still appears under User facing changes. So the checkbox and the label are not in sync. I think I'll add a commit to change that as well.

Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should make sure that we don't forget to label a PR and it accidentally goes into user facing changes.

Copy link
Collaborator

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks !

@dacook dacook merged commit bb19151 into openfoodfoundation:master Jan 18, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical changes only These pull requests do not contain user facing changes and are grouped in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants