Update variant name, price and stock through the DFC API #12037
Conversation
A DFC SuppliedProduct relates to a Spree::Variant and when updating its name we only want to change the name for that variant. Otherwise, when we update the name of the product, it would update the name for all variants and all the corresponding SuppliedProducts.
The DFC Connector doesn't support importing null values. This has to wait until it's solved in the Connector or we have an urgent use case.
The DfcBuilder was doing everything to start with but we are moving its parts to smaller modules now.
mkllnk
added
the
api changes
| @@ -49,10 +49,10 @@ def self.import_product(supplied_product) | |||
|
|
|||
| def self.apply(supplied_product, variant) | |||
| variant.product.assign_attributes( | |||
| name: supplied_product.name, | |||
| description: supplied_product.description, | |||
There was a problem hiding this comment.
Would this be a problem for description also?
Or do we need to keep this in order to achieve the current project..
There was a problem hiding this comment.
Would this be a problem for description also?
Yes, variants don't have descriptions, only products do. And when you change it through one variant then all get changed. It's a limitation we can't avoid at the moment. Better than no description update at all.
| context "with missing stockLimitation" do | ||
| let(:offer) { | ||
| offer_example.dup.tap do |o| | ||
| o.delete(:'dfc-b:stockLimitation') |
There was a problem hiding this comment.
Would the absence of a property imply a null value? That seems risky to me: if you sent just one property to be updated, you could inadvertently clear all others. I think it would need to explicitly send a null value.
I think we've had the discussion before, but I forget sorry.
There was a problem hiding this comment.
Yes, it's not great. And I wouldn't apply this rule in general. But the DFC recommends this for stockLimitation, probably in absence of a better solution. There's no way to express infinity as real value in JSON.
There was a problem hiding this comment.
We could propose a new value, of course. Something like our on_demand flag. But that can then be confusing in combination with the stock limitation value. 🤷
What? Why?
There were a few remaining fields left to import products via the DFC API. These have now been added with one exception. The issue also listed setting
on_demandbut that's currently not possible with the DFC Connector:What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates