Hotkey fix #12052
Merged
Hotkey fix #12052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A StimulusReflex form handler was being ignored, resulting in an error. Note that this method can support angular forms, the submit buttons just need to be updated to type='submit' (why they are not already boggles me).
Oops.
mkllnk
approved these changes
Jan 18, 2024
Me too! It appears to be a very straightforward change, but there may be a reason it was set up that way. And there are a lot of forms to test, so I decided not to go down the rabbit hole this time ;) |
|
Hi @dacook, I was able to reproduce the "not found" message before staging your PR: After staging we now have the same behavior on page /products for
Great fix! Thanks again! |
mkllnk
added
the
technical changes only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
I found an issue with the
ctrl+enterkeyboard shortcut on a StimulusReflex form, and fixed it.What should we test?
With admin_style_v3 enabled,
/admin/productsctrl+enter(orcmd+enteron mac)The change should be saved successfully.
Before, it would ask if you want to leave the site, and if you click yes, you got an error "Not found".
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates