Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump prettier and pretty-quick #12064

Merged
merged 2 commits into from
Jan 21, 2024

Conversation

dacook
Copy link
Member

@dacook dacook commented Jan 18, 2024

What? Why?

What should a dev test?

Update some JS or admin v3 CSS. stage and commit to see if the pre-commit hook functions as expected.

It's supported by the latest version of pretty-quick now.
@dacook dacook added dependencies technical changes only These pull requests do not contain user facing changes and are grouped in release notes labels Jan 18, 2024
@dacook dacook requested a review from rioug January 18, 2024 22:06
@dacook dacook added the dev-test A dev need to test this one label Jan 18, 2024
Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, found no issues locally.

@mkllnk mkllnk merged commit 1f5541d into openfoodfoundation:master Jan 21, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies dev-test A dev need to test this one technical changes only These pull requests do not contain user facing changes and are grouped in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants