chore(deps): bump flipper, flipper-active_record and flipper-ui #12111
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
|
|
abdellani
force-pushed
the
dependabot/bundler/flipper-and-flipper-active_record-and-flipper-ui-1.2.2
branch
from
d6ba34c
to
6c685bf
Compare
|
|
abdellani
force-pushed
the
dependabot/bundler/flipper-and-flipper-active_record-and-flipper-ui-1.2.2
branch
from
1fbedda
to
28a10b0
Compare
abdellani
force-pushed
the
dependabot/bundler/flipper-and-flipper-active_record-and-flipper-ui-1.2.2
branch
from
28a10b0
to
069f227
Compare
config/application.rb
Outdated
| @@ -253,5 +253,6 @@ module ::Reporting; end | |||
| config.exceptions_app = self.routes | |||
|
|
|||
| config.view_component.generate.sidecar = true # Always generate components in subfolders | |||
| config.flipper.test_help = false | |||
There was a problem hiding this comment.
May I suggest an alternative solution?
We are doing our test setup before the whole test suite runs:
openfoodnetwork/spec/base_spec_helper.rb
Lines 99 to 103 in 5f302f3
If we just call the FeatureToggle.setup! before each test run then that may solve the problem, too. And then we are working with the default test config for Flipper.
There was a problem hiding this comment.
Hi @mkllnk
replace suite with each, is that what you're asking me to do?
config.before(:each) do
Flipper.features.each(&:remove)
OpenFoodNetwork::FeatureToggle.setup!
end if yes, it's not working.
There was a problem hiding this comment.
I still don't know what's happening here. The specs pass locally but fail on CI. Maybe it's about KnapsackPro? I don't know how they implemented the queue.
Resetting Flipper seems to happen at the right time. But maybe KnapsackPro starts a new thread which uses a new Flipper instance with a new memory adapter? It doesn't make sense to me.
abdellani
force-pushed
the
dependabot/bundler/flipper-and-flipper-active_record-and-flipper-ui-1.2.2
branch
from
069f227
to
0220933
Compare
mkllnk
force-pushed
the
dependabot/bundler/flipper-and-flipper-active_record-and-flipper-ui-1.2.2
branch
from
0220933
to
1847948
Compare
Bumps [flipper](https://github.com/flippercloud/flipper), [flipper-active_record](https://github.com/flippercloud/flipper) and [flipper-ui](https://github.com/flippercloud/flipper). These dependencies needed to be updated together. Updates `flipper` from 0.26.2 to 1.2.2 - [Release notes](https://github.com/flippercloud/flipper/releases) - [Changelog](https://github.com/flippercloud/flipper/blob/main/Changelog.md) - [Commits](flippercloud/flipper@v0.26.2...v1.2.2) Updates `flipper-active_record` from 0.26.2 to 1.2.2 - [Release notes](https://github.com/flippercloud/flipper/releases) - [Changelog](https://github.com/flippercloud/flipper/blob/main/Changelog.md) - [Commits](flippercloud/flipper@v0.26.2...v1.2.2) Updates `flipper-ui` from 0.26.2 to 1.2.2 - [Release notes](https://github.com/flippercloud/flipper/releases) - [Changelog](https://github.com/flippercloud/flipper/blob/main/Changelog.md) - [Commits](flippercloud/flipper@v0.26.2...v1.2.2) --- updated-dependencies: - dependency-name: flipper dependency-type: direct:production update-type: version-update:semver-major - dependency-name: flipper-active_record dependency-type: direct:production update-type: version-update:semver-major - dependency-name: flipper-ui dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
It fails in CI and features are not seen as enabled. So we copy the important part of the test helper into our code, which works. It's probably about the point in time when the adapter is instantiated.
mkllnk
force-pushed
the
dependabot/bundler/flipper-and-flipper-active_record-and-flipper-ui-1.2.2
branch
from
1847948
to
ea0558c
Compare
|
@abdellani, I tried using the provided test helper but I couldn't get it to work either. I think that it gets loaded at the wrong time because we initialise Flipper earlier already. We may be able to solve that by converting our custom setup code to an adapter. Maybe after the next update:
I'm not sure if it would work though. Anyway, I deactivated the test helper like you did and brought in the change to a memory store because it's faster. |
rioug
deleted the
dependabot/bundler/flipper-and-flipper-active_record-and-flipper-ui-1.2.2
branch
Bumps flipper, flipper-active_record and flipper-ui. These dependencies needed to be updated together.
Updates
flipperfrom 0.26.2 to 1.2.2Release notes
Sourced from flipper's releases.
... (truncated)
Commits
dd54868Release 1.2.2e947540Merge pull request #827 from flippercloud/test-help-fixesbcafbc4Reconfigure in integration test68e2f73TestHelp: Reconfigure once, remove all features before each test6384a80Merge pull request #820 from flippercloud/stop-global-warming5df0121Merge remote-tracking branch 'origin/main' into stop-global-warming52c47e4Merge pull request #824 from flippercloud/cli-bundler-colorize12eef0eTest colorization in specsd0c4ba7Merge remote-tracking branch 'origin/main' into cli-bundler-colorize8ba0b5cTry increasing process_timeout on system testUpdates
flipper-active_recordfrom 0.26.2 to 1.2.2Release notes
Sourced from flipper-active_record's releases.
... (truncated)
Commits
dd54868Release 1.2.2e947540Merge pull request #827 from flippercloud/test-help-fixesbcafbc4Reconfigure in integration test68e2f73TestHelp: Reconfigure once, remove all features before each test6384a80Merge pull request #820 from flippercloud/stop-global-warming5df0121Merge remote-tracking branch 'origin/main' into stop-global-warming52c47e4Merge pull request #824 from flippercloud/cli-bundler-colorize12eef0eTest colorization in specsd0c4ba7Merge remote-tracking branch 'origin/main' into cli-bundler-colorize8ba0b5cTry increasing process_timeout on system testUpdates
flipper-uifrom 0.26.2 to 1.2.2Release notes
Sourced from flipper-ui's releases.
... (truncated)
Commits
dd54868Release 1.2.2e947540Merge pull request #827 from flippercloud/test-help-fixesbcafbc4Reconfigure in integration test68e2f73TestHelp: Reconfigure once, remove all features before each test6384a80Merge pull request #820 from flippercloud/stop-global-warming5df0121Merge remote-tracking branch 'origin/main' into stop-global-warming52c47e4Merge pull request #824 from flippercloud/cli-bundler-colorize12eef0eTest colorization in specsd0c4ba7Merge remote-tracking branch 'origin/main' into cli-bundler-colorize8ba0b5cTry increasing process_timeout on system testYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)