Fix Customer Search Autofill Issue

[chahmedejaz]

What? Why?

• Closes [BO Orders] Clicking customer search results does not fill the details form #12085

Issue

• There's an edge case where this.items might not have the selected customer
  

  openfoodnetwork/app/webpacker/controllers/select_customer_controller.js

  Line 27 in a6431bd

  const customer = this.items.find((item) => item.id == id);

• This is because we are always replacing this.items with the latest search results.
• As shown in the repro steps, if no value is being searched, then the dropdown displays all the previous search results as well
• This PR merges the latest search results into this.items so that we always have all the searched items in this.items hence mitigates the case where the selected customer might not be present in this.items

What should we test?

• Steps as explained here:
  • [BO Orders] Clicking customer search results does not fill the details form #12085 (comment)

Release notes

Changelog Category (reviewers may add a label for the release notes):

• User facing changes
• API changes (V0, V1, DFC or Webhook)
• Technical changes only
• Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

[rioug]

Nice one ! Thanks for your help @chahmedejaz

[filipefurtad0]

Hey @chahmedejaz ,

Thank you so much for your PR and your explanation on the previous video, this was really very helpful.

I've reproduced your steps, and could verify the bug is fixed. It is looking great:
https://www.loom.com/share/bc1b078550194289be82acd8a1fe09ce?sid=157a90cf-be74-4dca-977a-73c753916e3d

then the dropdown displays all the previous search results as well

Indeed, and as you demonstrate, this is the case. I have no strong opinion on it, if we actually really need it, or would be best to show no results, after an option was selected. Perhaps we can consider it an additional improvement, further on.

Thank you so much for clarifying and fixing the issue 💪
Merging!