-
-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrects setup for setup in credit card cloner spec #12127
Corrects setup for setup in credit card cloner spec #12127
Conversation
075cee7
to
65961d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, but you are missing the api key now. I needed this to get it working:
before {
Stripe.api_key = ENV.fetch('STRIPE_SECRET_TEST_API_KEY', nil)
}
65961d0
to
7738e58
Compare
Yes, absolutely. I've mixed it up with another PR (#12104, which is not yet merged and might make stating |
We should not need additional hard coded keys other than the API key and the CLIENT_ID; this PR removes hard coded customer ID - creates one instead Undoes Stripe.api_key deletion This was a mixup with an ongoing PR in which we remove the need to call api_key in each individual spec.
7738e58
to
769ccfd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. That works for me now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, so the test is more self-contained now 👍
We should not need additional hard coded keys other than the API key and the CLIENT_ID;
What? Why?
A PR has been merged with additional hard coded
STRIPE_CUSTOMER
andSTRIPE_ACCOUNT
, which seem incorrect to me:customer_id
will be invalidstripe_account
in this test; connected accounts should be as well created by demand.What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates