Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove update script, use bin/setup instead #12128

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

mkllnk
Copy link
Member

@mkllnk mkllnk commented Feb 6, 2024

What? Why?

We got bin/setup for the initial setup of the Rails environment and subsequent updates when switching branches. The bin/update script is not needed and hasn't been maintained.

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@mkllnk mkllnk added the technical changes only These pull requests do not contain user facing changes and are grouped in release notes label Feb 6, 2024
@mkllnk mkllnk self-assigned this Feb 6, 2024
@mkllnk mkllnk marked this pull request as ready for review February 6, 2024 21:55
Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@dacook dacook merged commit 7992d91 into openfoodfoundation:master Feb 8, 2024
52 checks passed
@mkllnk mkllnk deleted the bin-update branch February 9, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical changes only These pull requests do not contain user facing changes and are grouped in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants