Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes UnionPay (debit) from non-3DS card list #12135

Conversation

filipefurtad0
Copy link
Contributor

@filipefurtad0 filipefurtad0 commented Feb 7, 2024

Not sure why, but creating a payment intent with a UnionPay (debit) card, was leading to an unexpected (Stripe) payment state causing a shared examples set to fail:


  1) Stripe::PaymentIntentValidator#call when payment intent is valid valid 3D cards are correctly handled behaves like payments intents from UnionPay (debit) captures the payment
     Failure/Error:
       expect(Stripe::PaymentIntent.retrieve(
         payment_intent.id
       ).status).to eq("requires_capture")
     
       expected: "requires_capture"
            got: "requires_action"
     
       (compared using ==)
     Shared Example Group: "payments intents" called from ./spec/lib/stripe/payment_intent_validator_spec.rb:99

What? Why?

I'm quite positive this was passing before, and can't explain it right now. The reply points to a 3D2S processing. More context on the investigation here.

The pragmatic approach is to move this card to it's own, 3D2S context, and set it as pending. We can later improve the spec and add test cases for other 3DS and 3D2S cards.

What should we test?

  • green build

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@filipefurtad0 filipefurtad0 added the technical changes only These pull requests do not contain user facing changes and are grouped in release notes label Feb 7, 2024
@filipefurtad0 filipefurtad0 self-assigned this Feb 7, 2024
@mkllnk mkllnk merged commit b20bfae into openfoodfoundation:master Feb 7, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical changes only These pull requests do not contain user facing changes and are grouped in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants