[BUU] Add Unit Scale select #12183
Draft
[BUU] Add Unit Scale select #12183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dacook
force-pushed
the
buu/unit-scale-12005
branch
2 times, most recently
from
e170c0a
to
51d3ba3
Compare
| describe "#scale_for_unit_value" do | ||
| describe "#variant_unit_options" do | ||
| let(:available_units) { "mg,g,kg,T,mL,cL,dL,L,kL,lb,oz,gal" } | ||
| subject { WeightsAndMeasures.variant_unit_options } |
There was a problem hiding this comment.
if subject(:instanciated_class) { WeightsAndMeasures.new(your_argument).variant_unit_options }
than the include will work
There was a problem hiding this comment.
As I can guess, it is like a decorator. You might also consider leave this class untouched and create the decorator to deal with the decorated argument. Sounds good?
dacook
force-pushed
the
buu/unit-scale-12005
branch
3 times, most recently
from
ef2fd4a
to
5b649cd
Compare
Table layout is tricky. I had originally hoped that the table would allow us to use min/max width. But that simply doesn't work with `table-layout: fixed`. So we need to set preconfigured widths. Now I think that table layout doesn't bring any benefit, so I think we should consider switching to flexbox or grid. ButI'll wait until all elements are in place before trying anything new.
This is because it's going to move from product to variant soon, as part of Product Refactor.
This re-implements Angular JS function VariantUnitManager.variantUnitOptions() Well.. almost. See next commit.
Who would have guessed it was this complicated. Fingers crossed this doesn't break any other functionality...
A better way to arrange it, and as a bonus it makes the selectors simpler, yay!
I can't see any reason that fieldsets, which are containers, should share styles with inputs. Maybe font styles, but everything looks fine still.
This is more flexible and can find a field based on name, id or aria-label
The rem units are converted to em to make the padding relative to the chevron size. This means different font sizes will Just Work.
Thankfully I was able to use basic DOM features, so there's no coupling of the logic with tom-select. It wasn't going to be simple to get tom-select to listen for the 'changed' class on the original select, so I found a simple solution with a CSS sibling selector instead.
but tomselect is intent on closing the dropdown and not letting me focus it.
dacook
force-pushed
the
buu/unit-scale-12005
branch
from
5b649cd
to
aa4e5a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates