prevent generating invoices when order's distributor can't generate invoices #12219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
abdellani
force-pushed
the
prevent-generate-invoices-when-distributor-cannot-invoice
branch
from
0ba4fe0
to
ee1f608
Compare
mkllnk
approved these changes
Feb 29, 2024
Comment on lines
22
to
28
| authorize! :invoice, @order | ||
| OrderInvoiceGenerator.new(@order).generate_or_update_latest_invoice | ||
| if @order.distributor.can_invoice? | ||
| authorize! :invoice, @order | ||
| OrderInvoiceGenerator.new(@order).generate_or_update_latest_invoice | ||
| else | ||
| flash[:error] = t(:must_have_valid_business_number, | ||
| enterprise_name: @order.distributor.name) | ||
| end |
There was a problem hiding this comment.
My first thought was why we don't include that check in the Abilities class to have one source of truth. But that wouldn't provide us with a good error message. I guess that's one downside of CanCan.
drummer83
added
pr-staged-au
|
Hi @abdellani, |
sigmundpetersen
added
the
technical changes only
|
conflict resolved. |
mkllnk
approved these changes
Apr 23, 2024
|
Sorry for taking this long to test this one, I took the time to test other invoices related stuf - will open some issues about them #neverendingstory This PR is ready to go! The message looks nice in the new v3 style :)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
When I worked on this PR, we accidentally discovered that it's possible to generate invoices while the order's distributor can't generate invoices.
Check the following comments for more details:
#11918 (comment)
#11918 (comment)
What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates