Publish enterprise website with https:// #12410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkllnk
added
the
api changes
dacook
reviewed
Apr 23, 2024
Comment on lines
24
to
27
| websites: [enterprise.website].compact, | ||
| ).tap do |e| | ||
| # The model strips the protocol and we need to add it: | ||
| e.websites = e.websites.map { |url| "https://#{url}" } |
There was a problem hiding this comment.
Could this be done above on line 24?
There was a problem hiding this comment.
Yes, but I would need to add a new method because of the conditionals. The website may be blank and we can't just add "https://" to it in that case. Or do you mean adding the map on that line? Yes, it would probably fit.
There was a problem hiding this comment.
I'm not sure if the website could be an empty string, but it might be worth using compact_blank to cater for that.
There was a problem hiding this comment.
Good point. I'll update that.
dacook
approved these changes
Apr 29, 2024
|
Single review is sufficient |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Related to:
We strip all
http://andhttps://from enterprise URLs and addhttp://in the frontend. While we should fix the data model, I added a quick fix to the DFC API to publish the website URL withhttps://so that it can be used in links straight away.What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates