Optimise CI #12418
Optimise CI #12418
Conversation
Conversely, these tests are JS-only.
But surely we could convert it to a shell or node script. Maybe next time..
It saves the second unnecessary Rails boot-up (multiple seconds).
These tests don't run in the browser, therefore shouldn't need JavaScript at all.
But models can still run without. Half of the controller runs also succeeded, so we could potentially separate those ones out. Hmm, yes only 7 of them. It would save 20s, or 16% of controller CI runtimesi which are 2min. let's try..
dacook
added
the
technical changes only
Arrgh it's not so simple. It looks like both rspec and knapsack use glob for the pattern, so the pattern needs updating. Hmm that might not be too bad, but it makes it even less manageable. Considering the system specs are a much bigger bottleneck, I'm going to avoid spending more time here.
|
Now the model specs are running faster, I think we could use one less runner. Currently: If we use 4, it will still be less than 3m: All system specs take longer than 3 min, so it's no slower. We can give the extra runner to system_admin specs, which are the slowest. But we still have a bottleneck: So I'll try and look at these this week:
Oh and can we configure knapsack to use our |
What? Why?
One day the JS installation failed on a model spec, and I wondered why we would install JS anyway?
Today I decided to dive in and tried a few things. Some of them worked 馃帀
I left some history in, in case anyone's interested. Otherwise just review the overall diff.
What should we test?
green specs