Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12372-[Admin] Missing translations page titles #12454

Conversation

arunguleria
Copy link
Contributor

@arunguleria arunguleria commented May 9, 2024

What? Why?

What should we test?

The page titles of the following admin pages are always shown in English and they are not translated to the selected locale.

  1. 'Overview'
  2. 'Properties'
  3. 'Product Import'
  4. 'Subscriptions'
  5. 'General Settings'
  6. 'Enterprise Roles'

The translation for these are missing in locale file . For now I added the locales in en.yml file.

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes

The title of the pull request will be included in the release notes.

Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@filipefurtad0 filipefurtad0 added the user facing changes Thes pull requests affect the user experience label May 15, 2024
@filipefurtad0 filipefurtad0 self-assigned this May 15, 2024
@filipefurtad0 filipefurtad0 added the pr-staged-fr staging.coopcircuits.fr label May 15, 2024
@filipefurtad0
Copy link
Contributor

Hey @arunguleria 👋
Is this your first contribution? Welcome!!

I've checked the relevant pages, assuring these render correctly, and commented where relevant:

  • 'Overview'

image

  • 'Properties'

This seems to be already translated:

image

  • 'Product Import'

image

  • 'Subscriptions'

I think this was already translated before:

image

image

All pages render well! Some are already translated and I think general settings might still be missing, but we can check this in production.

Thanks so much!
Merging 🎉

@filipefurtad0 filipefurtad0 merged commit b67eba2 into openfoodfoundation:master May 15, 2024
54 checks passed
@sigmundpetersen sigmundpetersen removed the pr-staged-fr staging.coopcircuits.fr label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user facing changes Thes pull requests affect the user experience
Projects
Status: Done
4 participants