Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show any tax category errors when saving variants #12486

Merged
merged 3 commits into from
May 21, 2024
Merged

Show any tax category errors when saving variants #12486

merged 3 commits into from
May 21, 2024

Commits on May 16, 2024

  1. Associate label with checkbox 

    Now you can click on the text to tick/untick the box. I've been wanting to do that for ages.
    @dacook
    dacook committed May 16, 2024
    Configuration menu
    Copy the full SHA
    412c110 View commit details
    Browse the repository at this point in the history

  2. Show error messages and highlight for bulk editing 

    The validation message is on "tax_category", so labels and error messages can use that to show the error state.
But the select field has to be "tax_category_id" to work.
    @dacook
    dacook committed May 16, 2024
    Configuration menu
    Copy the full SHA
    3e1e7d3 View commit details
    Browse the repository at this point in the history

  3. Display red border around invalid selects 

    I developed this while going down a slightly different path. I tested it visually, but the case I tested doesn't exist. I'm confident it will work if we ever have an error on another select though.
    @dacook
    dacook committed May 16, 2024
    Configuration menu
    Copy the full SHA
    e0c60aa View commit details
    Browse the repository at this point in the history