Fixes offenses raised by Rails/UnusedRenderContent #12582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- in any cases, adding status: :no_content dropes content from response - replaced by head :no_content (HTTP 204)
23 tasks
rioug
added
the
technical changes only
rioug
approved these changes
Jun 18, 2024
It looks like there's no change to the API:
So the content was already dropped and not sent to the client. The response should look exactly the same now. |
mkllnk
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Contributes to #11482
The: Rails/UnusedRenderContent Cop checks offenses when both sending some content AND a non-content status code.
In any cases, adding
status: :no_content(with content) drops content from responseSo, I replaced with
head :no_content( that is: HTTP code 204)What should we test?
Nothing.
Automatic specs should all pass.
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates