Fix Voucher Code Field Focus Issue

[chahmedejaz]

What? Why?

• Closes Voucher code field at checkout only allows one character #12632
• Currently, we are using the generic toggle_control_controller to enable the Apply button if the voucher code is present.
• This controller focuses the control after performing some toggle action on it i.e. after enabling etc.
• In this case, the control is a submit button (Apply), and when user enters the voucher code, and after that the controller enables the Apply button and focuses it. Hence, the focus is lost from the Voucher Code input field.
• I assume the focus functionality was intended for text-related fields, so this PR adds the check such that if the control is a button, then it won't be focused. Hence, the currently focused field will remain focused.

What should we test?

• On the checkout page, when entering the voucher code, the field should remain focused and let you fill in the entire code without re-clicking it to focus after each character.

Release notes

Changelog Category (reviewers may add a label for the release notes):

• User facing changes
• API changes (V0, V1, DFC or Webhook)
• Technical changes only
• Feature toggled

[rioug]

Good one, could you update the related test as well ? thanks !

[chahmedejaz]

Good one, could you update the related test as well ? thanks !

Ah, sorry about that. I missed the Jest specs. Let me update that and get back to you. Thanks.

[chahmedejaz]

Hi @rioug - Specs are updated here: ced3408. Please review and let me know if anything is missing. Thanks.

[dacook]

Great work, and thanks for updating the existing spec to cover this also 👍

[rioug]

Awesome, It looks good now thanks !

[RachL]

I didn't manage to successfully stage this one :( Don't know if it is linked to the errors we are seeing in master?

[sigmundpetersen]

@RachL I think this is due to the same out-of-memory issue on fr-staging.
A puma restart should suffice.

[sigmundpetersen]

This is how Filipe did it earlier #12485 (comment)

[RachL]

@sigmundpetersen ah good to know, thanks! but Filipe has ssh access, I don't :( FYI however I've tried staging AU and it failed as well

[sigmundpetersen]

Yes, same error on au-staging.
So either out of memory there as well, or there is another issue (on both)

[drummer83]

Hi @chahmedejaz,
Thank you for fixing this s2. 💪

I was able to reproduce the bug BEFORE this PR. After staging your solution, I couldn't see it anymore.

So I can confirms that the bug is fixed. That's great! Thank you!! 🙏

Kazam_screencast_00004.webm

Ready to go! 🚀 🥳