Change English choose_starting_point text for consistency #1992
Conversation
My environment set up removed some necessary code from Gemfile.lock. This commit adds them back.
Gemfile.lock
Outdated
|
|
||
| BUNDLED WITH | ||
| BUNDLED WITH |
There was a problem hiding this comment.
can we please leave this changes out of the PR?
|
Oh, also, @sauloperez will this need to be covered in transifex also? |
|
Yep, we should change this copy in Transifex cc @mkllnk |
| @@ -802,9 +802,8 @@ DEPENDENCIES | |||
| whenever | |||
| wicked_pdf | |||
| wkhtmltopdf-binary | |||
|
|
|||
| RUBY VERSION | |||
| RUBY VERSION | |||
There was a problem hiding this comment.
You probably didn't mean to change this file. Can you revert your change?
| @@ -529,7 +529,7 @@ en-GB: | |||
| welcome_title: Welcome to the Open Food Network! | |||
| welcome_text: You have successfully created a | |||
| next_step: Next step | |||
| choose_starting_point: 'Choose your starting point:' | |||
| choose_starting_point: 'Choose your package:' | |||
There was a problem hiding this comment.
One thing you couldn't know, is that we change only en.yml manually. That is our source locale that gets translated with Transifex. The translations from Transifex get then merged into our code automatically. So if you could revert you changes on all other locales, that would be great. Otherwise we will face merge conflicts.
|
@jenPlusPlus just wondering if you would like to finish that one? It's been open for a long time. Else let us know and we'll ask if someone can take over :-) |
|
Does anyone want to finish that one? Else let's just close and someone will do it at some point. Funny to see that this PR was a copy of a PR done on a fork of OFN referenced in #1926 but they didn't take transifex into account hahaha ;-) |
|
Let's close it for now |
What? Why?
We changed all text (in English) that read, "Choose your starting point" to "Choose your package"
Closes #1926
This change was needed to increase consistency. Feedback from users indicated that there was confusion between terms like profile, type, and package.
We ran into a challenge when handling this issue:
We were unable to locate the issue in the interface of the application. However, we were able to find it and change the text in the codebase. We aren't able to confirm the change in the user interface of the application without recreation steps.
We had difficulty installing dependencies using rbenv. We found success using RVM.
What should we test?
Testing is needed to verify that the user interface of the application is displaying the desired text.