Better docs for Stripe.publishable_key and Stripe.endpoint_secret. #2798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauloperez
reviewed
Oct 1, 2018
| @@ -4,6 +4,8 @@ | |||
| # a bit cleaner than accessing keys in different ways. | |||
| module Stripe | |||
| class << self | |||
| # Returns the value of Stripe.publishable_key and Stripe.endpoint_secret. | |||
| # Attribute values can also be set by doing Stripe.publishable_key = <your_new_value> | |||
There was a problem hiding this comment.
I think it would be worth also to mention Stripe.endpoint_secret = <your_new_value>
There was a problem hiding this comment.
Would you like to address this comment @as1729? Then it can be approved and merged
|
Thanks a lot for your contribution @as1729 and welcome to the Open Food Network! Don't hesitate to pick any good first issue and join us on Slack. Besides, in the README file you'll find everything you need to know. |
mkllnk
approved these changes
Oct 9, 2018
|
@sauloperez Are you happy to approve this PR? @as1729 doesn't seem to be active any more. |
|
Yes, let's move it forward. |
sauloperez
approved these changes
Oct 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
The change adds some additional documentation to attr_accessor functions.
What should we test?
No testing should be required.
Release notes
Added developer documentation.
Changelog Category: Added
Documentation updates
None required as far as I am aware.