Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix orders controller spec #3456

Conversation

sauloperez
Copy link
Contributor

@sauloperez sauloperez commented Feb 7, 2019

What? Why?

Closes #2685

spec/controllers/spree/orders_controller_spec.rb:227 was not passing. This fixes it.

What should we test?

All spec/controllers/spree/orders_controller_spec.rb specs should pass

@sauloperez sauloperez self-assigned this Feb 7, 2019
@sauloperez sauloperez removed the pr-wip label Feb 7, 2019
@sauloperez
Copy link
Contributor Author

Passing 🍏

And the second one is open.
Fix typo in doc

Co-Authored-By: sauloperez <saulopefa@gmail.com>
Copy link
Member

@kristinalim kristinalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🙂

@sauloperez sauloperez merged commit b6ca0ba into openfoodfoundation:2-0-stable Feb 12, 2019
@sauloperez sauloperez deleted the fix-last-orders-controller-spec branch February 12, 2019 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants