Perform delivery when checking deliveries in specs #3497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise checking `ActionMailer::Base.deliveries.count` won't see any.
luisramos0
approved these changes
Feb 14, 2019
|
It must be related to ordering and global state. If any other test changes ActionMailer's config chances are that this test depended on it (I guess). |
|
Are there other tests that also need the same wrapper? |
|
This seems to be the last spec that was needing it. Others were already applied. |
|
The test is passing and the others are already fixed in other PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #3486
Otherwise checking
ActionMailer::Base.deliveries.countwon't see any email. In test, they won't be sent but put intodeliveries.What should we test?
spec/controllers/user_confirmations_controller_spec.rb:70 should pass