User friendly error when creating a product with an image in an unsupported format #3923
Conversation
luisramos0
force-pushed
the
prod_image_error
branch
from
8002300
to
1ae232f
Compare
luisramos0
changed the title
| @@ -33,6 +33,10 @@ def create | |||
| delete_stock_params_and_set_after do | |||
| super | |||
| end | |||
| rescue Paperclip::Errors::NotIdentifiedByImageMagickError | |||
| invoke_callbacks(:create, :fails) | |||
| @object.errors.add(:base, t('spree.admin.products.image_upload_error')) | |||
There was a problem hiding this comment.
may I suggest we let the user know which formats we accept? I think this is the kind of messages that confuse the user "which format am I supposed to use?"
There was a problem hiding this comment.
tbh I have no clue what is that list...
I dont see this ImageMagick in our dependencies list... do you know if we use it?
There was a problem hiding this comment.
Maybe we can recommend common formats?
- Error uploading image, you may need to use a different image format
+ This image was not recognised. Please upload an image in PNG or JPG format.
There was a problem hiding this comment.
We install ImageMagick via ofn-install I think.
There was a problem hiding this comment.
nice one, I found this list: https://imagemagick.org/script/formats.php
Matt: that would make sense.
I'll follow Maikel's advise, looks reasonable.
…and send appropriate error message to client when product image upload fails
luisramos0
force-pushed
the
prod_image_error
branch
from
1ae232f
to
a7c9700
Compare
|
@luisramos0 I didn't manage to make it work. I always have an error 500 even with good format like .png or .jpg (by the way I think we need to list these formats somewhere). Here are my testing notes with link to the image: Back to you |
|
image uploads are broken in staging FR, can you pls test this in staging uk for example? |
|
@luisramos0 indeed it works on UK staging. however I've noticed that you added that friendly message only to product creation, not editing. Is that correct? So we need to open a new issue for that. Moreover, uploading a .svg image does not work as well, but the user is not warned, he only sees an empty spot:
|
|
nice. the goal here is really to guide the user who is creating a product and sees a snail because of the image but has no clue what field is causing the problem... there's no image in product edit, only edit images, it's a different problem and not so important. see last paragraph here: I'd create a new issue for that and also for the svg problem you describe. |
|
@luisramos0 if you use the submenu Images in product edit and you upload an unknown format, you will see a snail / Error 500. Same pattern than in product creation. If you click on the image in the bulk edit page, then the spinner will stop at some point with no indication. This is indeed less bad. But yes let's merge this as it improves the current situation anyway. I've opened #3976 for the error 500 and #3975 for the other type of image file. |
|
yes :+1 in both those situations the user is explicitly updating the image, so the user will know the image is the problem. when creating a product, the user has no clue if it's the image or some other field. |
What? Why?
Closes #764
Instead of a stack trace the user now sees a nice error message:
We do this by catching the exception in the controller.
What should we test?
Product creation still works correctly.
Uploading a good image still works.
Uploading an image in a weird format (I tested with exr) shows a friendly error.
Release notes
Changelog Category: Fixed
Creating a product with an unsupported image format now shows a user friendly error.