Add default date range to Delivery Report #4260
Conversation
There was a problem hiding this comment.
awesome @jasonk357 ! Welcome onboard 🎉
I think putting the work here in a background job would make more sense but given the context maybe that isn't necessary?
That's very interesting. I recently got a similar suggestion from someone else. What if we unblocked the app server by performing it async and send an email to the user when done?
|
Hi @jasonk357, welcome :-) The default date and time appears now, for both report types - thank you. The "now" button on the calendar provides the date/time for the local system in use and not the actual hub, which might lead to some discrepancies when these are not on the same timezone. I am wondering whether the "now" button should provide the timestamp of the hub instead? You can find details on |
|
Hi @sigmundpetersen 🙂 I see you've staged this on FR previously. I've tested it and it seems ok, should I move it to Ready to Go for further review, or are you still checking something? |
|
Hey @filipefurtad0 I just added the label after you staged it 😉 Please move to ready if you are happy with the test results 👍 |
|
Congratulations @jasonk357 and thanks for this contribution! 🎉 |
|
|
What? Why?
Closes #4184
This adds a default date range, the most recent month, to the parameters sent to the
OrderCycleManagementReport.I think putting the work here in a background job would make more sense but given the context maybe that isn't necessary?
What should we test?
Delivery report, payment methods report, with and without dates.
Release notes
Assigns a default date range from one month ago to today for the delivery report and payment methods report.
Changelog Category: Fixed
Woo first OFN PR!