Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring spree_backend payments controller to OFN #4509

Merged

Conversation

luisramos0
Copy link
Contributor

@luisramos0 luisramos0 commented Nov 27, 2019

What? Why?

Related to #4050

We bring payments_controller from spree_Backend and merge the decorator in OFN.

We fix some rubocop issues but leave abc size and method length on create and fire for later. These are reflected in the new todo_manual file.

What should we test?

We need to verify the page to capture payments in the order.
Create payment, capture payment, cancel payment.
We should test these things above with several order states as well as several payment methods.

There's this edge case where we delete the payment method and the list of payments of a past order with that payment method still shows the name of that deleted payment method correctly. I wonder if this is working in the current version. I havent tested this.

Release notes

Changelog Category: Changed
Brought the backoffice page that captures payments from spree to make OFN independent of Spree.

@luisramos0 luisramos0 self-assigned this Nov 27, 2019
@luisramos0 luisramos0 changed the title WIP Bring spree_backend payments controller to OFN Bring spree_backend payments controller to OFN Dec 14, 2019
@luisramos0 luisramos0 added pr-wip and removed pr-wip labels Dec 14, 2019
@luisramos0 luisramos0 removed the pr-wip label Dec 15, 2019
@Matt-Yorkley
Copy link
Contributor

Needs a rebase @luisramos0

@sigmundpetersen
Copy link
Contributor

Also needs a rebase

@luisramos0
Copy link
Contributor Author

👍 done

@RachL RachL self-assigned this Jan 28, 2020
@RachL
Copy link
Contributor

RachL commented Jan 28, 2020

@luisramos0 when I click on a payment method of an order, I get an error 500 and I don't see this in production. Could it be linked to this PR?

Example link: https://staging.katuma.org/admin/orders/R064445101/payments/174

image

image

@luisramos0
Copy link
Contributor Author

It was a bug in my migration of the code, I didn't see there was a show action. This link on the "payment method" column goes to a page that shows the payment...
It's now working. I just staged it to ES.

@luisramos0
Copy link
Contributor Author

ready for testing in katuma.

@RachL
Copy link
Contributor

RachL commented Feb 4, 2020

Great I think this is ready to go!

I've tested creating, capturing and cancelling on all 3 payments methods.

Also

There's this edge case where we delete the payment method and the list of payments of a past order with that payment method still shows the name of that deleted payment method correctly. I wonder if this is working in the current version. I havent tested this.

This is working as well 🎉

@RachL RachL removed the pr-staged-es label Feb 4, 2020
@luisramos0 luisramos0 merged commit c4bf4f0 into openfoodfoundation:master Feb 4, 2020
@luisramos0 luisramos0 deleted the backend_ctrl_payments branch February 4, 2020 11:46
@luisramos0 luisramos0 mentioned this pull request Feb 6, 2020
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants