Bump Code Climate's Rubocop version to their latest #4722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our used version is still higher than that.
sauloperez
approved these changes
Feb 4, 2020
|
I think those CodeClimate issues deserve a look we could fix some and some others to the todo. |
|
I went ahead and approved it in Code Climate. This is already good as it is and we can fix those issues later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
I noticed that Code Climate is using an older version of Rubocop. That explains why we see different results locally. In this PR I chose the most recent version supported by Code Climate which is closer to our used version.
Code Climate seems to be a bit behind which clashes with our Dependabot updates. Maybe we should not follow Dependabot here and always update rubocop manually. It needs manual intervention anyway. Let's see.
What should we test?
No test needed.
Release notes
Fine-tuned the configuration of our automated code quality control.
Changelog Category: Changed