4489 Flaky spec when editing outgoing exchanges in OC #4756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisramos0
approved these changes
Feb 4, 2020
sauloperez
approved these changes
Feb 4, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
The previous code was intermittently failing because of the race condition while clicking to open all panels for outgoing exchange products.
If the open trigger for the third exchange is clicked while the panels for the first and second exchanges are not yet open, the third exchange is pushed down to the bottom of the browser window already when the panels finally open. When this happens, the variant check boxes for the third exchange are no longer considered visible.
What should we test?
The test build should be green.
Release notes
Changelog Category: Fixed