Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inner join visible orders #4879

Merged
merged 3 commits into from Mar 10, 2020
Merged

Inner join visible orders #4879

merged 3 commits into from Mar 10, 2020

Commits on Mar 5, 2020

  1. Add controller tests to cover totals by supplier

    @sauloperez
    sauloperez committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    461b1b2 View commit details
    Browse the repository at this point in the history

  2. Replace LEFT JOIN with INNER JOIN 

    I see no reason why a LEFT might be needed and its the root cause of the
awful performance.
    @sauloperez
    sauloperez committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    53a6377 View commit details
    Browse the repository at this point in the history

  3. Rewrite INNER JOIN in ActiveRecord's DSL

    @sauloperez
    sauloperez committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    0042ab2 View commit details
    Browse the repository at this point in the history