Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt remaining AR finders to rails 4 #4925

Merged
merged 1 commit into from Aug 27, 2020

Conversation

luisramos0
Copy link
Contributor

@luisramos0 luisramos0 commented Mar 5, 2020

What? Why?

Final migration of finders to rails 4 style.

What should we test?

We should verify order customer details page is working correctly: it displays the details introduced on checkout and it allows manager to change some customer details.
We should verify for example product variants and images can be added, edited and deleted as usual.

Release notes

Changelog Category: Changed
Migrated some finders to rails 4 style, this will be necessary for rails 4.1 upgrade.

@luisramos0 luisramos0 self-assigned this Mar 5, 2020
@sauloperez sauloperez closed this Jun 15, 2020
@luisramos0 luisramos0 reopened this Jun 15, 2020
@luisramos0 luisramos0 changed the base branch from 3-0-stable to master June 15, 2020 11:46
@sigmundpetersen sigmundpetersen changed the title WIP [Spree 2.1 ] Adapt remaining AR finders to rails 4 WIP [Spree 2.1] Adapt remaining AR finders to rails 4 Aug 4, 2020
@luisramos0 luisramos0 changed the title WIP [Spree 2.1] Adapt remaining AR finders to rails 4 Adapt remaining AR finders to rails 4 Aug 16, 2020
@luisramos0 luisramos0 removed the pr-wip label Aug 16, 2020
@filipefurtad0 filipefurtad0 self-assigned this Aug 27, 2020
@filipefurtad0 filipefurtad0 added the pr-staged-uk staging.openfoodnetwork.org.uk label Aug 27, 2020
@filipefurtad0
Copy link
Contributor

Hey @luisramos0,

Thanks for the testing notes Luis.

Checked that the order customer details page is working as before:

  • the details introduced on checkout are displayed correctly
  • the manager can change some customer details
  • after these changes, these appear correctly on the invoices and orders (on the customers account)

Verified as well that:

Newly created items can always be deleted. But it seems to be a pattern, that limited stock products/variants cannot be deleted after orders have been placed. Orders placed on new items with unlimited stock, can be deleted. This worked, before and after this PR, so we are all good here.

  • product images
    can be added, edited and deleted as usual - all good here

  • variant images
    can be added but not deleted nor edited - a known bug Can't edit or delete variant images #5731, which I now updated as it seems editing is not possible as well

This is ready to go - thank you!

@filipefurtad0 filipefurtad0 removed the pr-staged-uk staging.openfoodnetwork.org.uk label Aug 27, 2020
@mkllnk mkllnk merged commit d57f20a into openfoodfoundation:master Aug 27, 2020
@luisramos0 luisramos0 deleted the finders branch August 29, 2020 18:39
@luisramos0
Copy link
Contributor Author

Nice, thanks Filipe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants