Admin Customers performance

[Matt-Yorkley]

What? Why?

Improves performance in admin customers page.

What should we test?

Admin customers page is working correctly, should be much faster for large hubs.

Release notes

Improved performance on admin customers page

Changelog Category: Fixed

[Matt-Yorkley]

Tested locally with a medium-sized hub (using production data). In production this endpoint regularly takes 40+ seconds to load.

BEFORE: 14.6 seconds and ~3200 queries

AFTER: 3.3 seconds and 26 queries

[Matt-Yorkley]

It would be really nice to extract this to the API, but I think it would require a lot more changes to be piled on top of this PR...

[luisramos0]

awesome!
I think we should try to look for other places where tags are killing us and improve 👌

[Matt-Yorkley]

I just double-checked some of the SQL before and after and I realised I forgot something crucial here! It's a polymorphic association, so we have to specify the class the tags are attached to:

New commit added. Hopefully we can extract this into a reusable service as some point and utilise it elsewhere.

[Matt-Yorkley]

Hopefully we can extract this into a reusable service as some point and utilise it elsewhere.

I had a quick look and it looks like we can use this to improve reports 💪

[luisramos0]

awesome, we should create an issue for that like: extract customer_tags_by_id and re-use it 🎉

[sauloperez]

have you tried defining this as an association and using AR association's :condition? This feels to me like something AR should do and not us.

We can improve it in a different PR if you prefer. I don't want to delay this PR.

[sauloperez]

👏

[filipefurtad0]

Hey @Matt-Yorkley ,

Uff. This one was a brainer to set up - and, well, made me very grateful this and all performance efforts :-)

In AU and as superadmin:

• I had a look in reports for an enterprise with plenty of customers, found Ballantyne (Thornbury).
• Turned over to which has over a hundred. navigated to Users > Permissions > and added a user to manage this enterprise
• logged into this users account
• navigated to /admin/customers/
• Reloaded the page and had a few screenshots, before and after the PR

Somehow, I could not "measure" a tangible difference... Load times for the /admin/customers/ page:

Before:

After this PR:

Perhaps the customer number isn't large enough?
Tried performing the usual operations here, as well, as in the users page. I found nothing unusual.

I'm moving this to ready to go, but adding the feedback label, just in case you feel there is anything more I should try here.

[Matt-Yorkley]

Thanks Filipe! Interesting results. I just had another look, and the optimisations here will apply more to larger hubs that have any/all of the following:

• lots of customers
• lots of card payments
• lots of completed orders
• using tagging on customers

I think Prom Coast Food Hub is a good one to go for if you're testing large hubs on Aus Staging.

[filipefurtad0]

Ah - that one has over 600 customers. I guess I should just have asked :-)
Great, I'll have a second look at this.
Thanks @Matt-Yorkley

[filipefurtad0]

Ok! Now things look quite different.

Time to refresh page:
Before PR: ~10 sec
After PR: ~5 sec

Time to display data, after clicking the [ Show all (589 more) ] button:
Before PR ~30 sec
After PR ~20 sec

Pic before PR:

Pic after PR:

Thanks for your help @Matt-Yorkley
Good to go.