Remove smtp config from admin config page

[luisramos0]

What? Why?

Closes #1534

This is a quick fix to 1534. We remove the fields because they need dev intervention: start/stop delayedjob.
Before:

After:

These values are updated on every deploy through the seeds task. The values are set in the secrets file used by ofn-install. This needs to be tested in staging as part of this PR.

What should we test?

We are still able to use the existing fields in this form and they still work.
As part of this PR we need to test that ofn-install will update the smtp password in the preferences table during a normal deploy.

Release notes

Changelog Category: Changed
Remvoed mail settings config from the UI as they can only be changed by developers.

[kristinalim]

This PR needs both dev-test and user test. Tagging this dev-test first.

[sauloperez]

UI-wise things work but I'm wondering about

One thing I can add in #5235 is to remove mail methods from spree_preference in a migration.

Do you plan to add this?

Re smtp password in the preferences table, in my docker dev setup db/seeds.rb successfully picks up the values from the available env vars set in config/application.yml. I'll check now in staging.

[luisramos0]

thanks for mentioning that. I forgot about that.
I rebased to resolve conflicts in db/schema and added the migration.

[sauloperez]

this will skip smtp_username and smtp_password though. Is that what we want?

[luisramos0]

yes, I think smtp_username and smtp_password are the values set in MailConfiguration and used in MailSettings.

[sauloperez]

ah ok, got it. These are old Spree preference and not ours. I wasn't sure what you were aiming at.

[sauloperez]

Confirmed it works.

openfoodnetwork=> select * from spree_preferences where key ilike '%mail_host%';
-[ RECORD 1 ]---------------------------------
id         | 2
value      | smtp.mandrillapp.com
created_at | 2019-07-23 10:01:26.371498
updated_at | 2020-04-29 11:43:10.463866
key        | spree/app_configuration/mail_host
value_type | string

openfoodnetwork=> delete from spree_preferences where key ilike '%mail_host%';
DELETE 1
openfoodnetwork=> select * from spree_preferences where key ilike '%mail_host%';
 id | value | created_at | updated_at | key | value_type 
----+-------+------------+------------+-----+------------
(0 rows)

*I deployed right here*

openfoodnetwork=> select * from spree_preferences where key ilike '%mail_host%';
-[ RECORD 1 ]---------------------------------
id         | 502
value      | smtp.mandrillapp.com
created_at | 2020-04-29 13:58:04.582884
updated_at | 2020-04-29 13:58:04.582884
key        | spree/app_configuration/mail_host
value_type | string

This is ready for regular testing.

[luisramos0]

great, thanks Pau!

[filipefurtad0]

Hi @sauloperez ,

Tested the remaining fields:

• send email
• send copy
• intercept email

Used the Send Test Email and tested whether all expected emails arrive on a signing-in process.

All work fine - ready to go.

[luisramos0]

oh, this was quick!!!