Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clone of #5176 #5237

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Clone of #5176 #5237

merged 1 commit into from
Apr 17, 2020

Conversation

luisramos0
Copy link
Contributor

@luisramos0 luisramos0 commented Apr 15, 2020 •
edited

See #5176

@luisramos0 luisramos0 changed the title Master with change Clone of #5176 Apr 15, 2020
@luisramos0 luisramos0 marked this pull request as ready for review April 15, 2020 18:04
@luisramos0 luisramos0 mentioned this pull request Apr 15, 2020
Closed
@filipefurtad0
Copy link
Contributor

Hi @Ekow244 ,
The PR is staged and now ready for testing.

@Ekow244
Copy link

Ekow244 commented Apr 16, 2020

@filipefurtad0 Please check out the Test Notes here:https://docs.google.com/document/d/1A0NM-hjsbOrD0YfMd9K-gtxKBc-FBramFi1kOIUCTA0/edit#

@filipefurtad0
Copy link
Contributor

Great testing @Ekow244!
Thank you for having a look at this PR and for your test notes.

Cheers to @chrishil1 for this improvement.

@mkllnk mkllnk merged commit a672af1 into openfoodfoundation:master Apr 17, 2020
@luisramos0 luisramos0 deleted the master_with_change branch April 17, 2020 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ekow244 Ekow244

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@luisramos0 @filipefurtad0 @Ekow244 @mkllnk @chrishil1