Fix search bar in /shops and /groups #5466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisramos0
approved these changes
May 19, 2020
sauloperez
approved these changes
May 21, 2020
|
Hey @Matt-Yorkley, Checked this after a somewhat suspicious deploy on Katuma. This PR fixes the issue: the search field in /shops has regained formatting and regained the it's functionality. Issue #5467 is observed in the /shops page as before. Interestingly this is not observed in /producers search. Moving to ready to go after an error-free deploy in FR. Adding the blocked-label. |
filipefurtad0
added
blocked
pr-staged-fr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Fixes bugs in the /shops and /groups search bars introduced recently. The styling was removed, and the search functionality was broken.
GIF from @filipefurtad0:
What should we test?
Search is working correctly in /shops and /groups
Release notes
Fixed issue with search bars in /shops and /groups