Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix group maps #5494

Merged
merged 3 commits into from May 29, 2020
Merged

Conversation

Matt-Yorkley
Copy link
Contributor

What? Why?

Closes #5473

What should we test?

  • Maps display is working again on groups pages.
  • Maps is working as normal on the main maps page.

Release notes

Fixed maps display in groups pages

Copy link
Contributor

@luisramos0 luisramos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impecável 👌

image

@@ -63,3 +63,8 @@
left: 0px;
}
}

.tabs-content .map-footer {
position: relative;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just out of curiosity why do we need to position it relatively? I don't see any absolute counterpart. Perhaps a screenshot will be best to explain it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's overlaid on the map, but in this case it's in the group page inside a tab. On the main map page the positioning is very different and fills the entire screen.

@sauloperez
Copy link
Contributor

Impecable 😂

@Matt-Yorkley
Copy link
Contributor Author

Screenshot from 2020-05-28 13-48-52

I'm not sure about some of these translations...

@luisramos0
Copy link
Contributor

In Porto style Portuguese, it translates to "Está do caralho!" translates to "It was really well done!"
This expression is more commonly used as "É do caralho" translates to "It is very good"

🤣

@RachL
Copy link
Contributor

RachL commented May 28, 2020

🤣 I'm loving this thread

@filipefurtad0 filipefurtad0 self-assigned this May 28, 2020
@daniellemoorhead daniellemoorhead added the pr-staged-au staging.openfoodnetwork.org.au label May 28, 2020
@daniellemoorhead daniellemoorhead self-assigned this May 28, 2020
@daniellemoorhead daniellemoorhead added pr-staged-es and removed pr-staged-au staging.openfoodnetwork.org.au labels May 28, 2020
@daniellemoorhead daniellemoorhead removed their assignment May 28, 2020
@sauloperez
Copy link
Contributor

sauloperez commented May 29, 2020

I find it very interesting that those expressions are used almost identically in Galicia @luisramos0 🤓 #galaicoPortugués 👌

@filipefurtad0
Copy link
Contributor

filipefurtad0 commented May 29, 2020

Hey @Matt-Yorkley ,

This is working again 🎉

image

Maps retain the previous functionality and the recently introduced improvement (showing overlaying enterprises as +1).
Thank you @daniellemoorhead for having a look on this one as well 👍
Ready to go.

@Matt-Yorkley Matt-Yorkley merged commit c73defa into openfoodfoundation:master May 29, 2020
@Matt-Yorkley
Copy link
Contributor Author

This needs to go in the release...

@luisramos0
Copy link
Contributor

@sauloperez
"Os idiomas galaico-portugueses são do caralho!" 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Groups Enterprises are not mapping
6 participants