New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix group maps #5494
Fix group maps #5494
Conversation
… positioning for /groups page map display
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -63,3 +63,8 @@ | |||
left: 0px; | |||
} | |||
} | |||
|
|||
.tabs-content .map-footer { | |||
position: relative; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just out of curiosity why do we need to position it relatively? I don't see any absolute counterpart. Perhaps a screenshot will be best to explain it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's overlaid on the map, but in this case it's in the group page inside a tab. On the main map page the positioning is very different and fills the entire screen.
Impecable 😂 |
In Porto style Portuguese, it translates to "Está do caralho!" translates to "It was really well done!" 🤣 |
🤣 I'm loving this thread |
I find it very interesting that those expressions are used almost identically in Galicia @luisramos0 🤓 #galaicoPortugués 👌 |
Hey @Matt-Yorkley , This is working again 🎉 Maps retain the previous functionality and the recently introduced improvement (showing overlaying enterprises as +1). |
This needs to go in the release... |
@sauloperez |
What? Why?
Closes #5473
What should we test?
Release notes
Fixed maps display in groups pages