New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Enter submit the form on both products and orders admin #5599
Make Enter submit the form on both products and orders admin #5599
Conversation
64198b3
to
e6e4b6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good enough IMO 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I prefer the option in the first commit. It's a lot more DRY, no?
yes, agree but i couldnt make it work for orders page. Do you want to have a look? Could be a very simple thing.
…Sent from my iPhone
On 17 Jun 2020, at 12:23, Matt-Yorkley ***@***.***> wrote:
@Matt-Yorkley commented on this pull request.
I think I prefer the option in the first commit. It's a lot more DRY, no?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
I'm of the opinion that better done than nothing, at least here. Then, we can spend some time improving it but knowing this is already done. |
so @Matt-Yorkley, which way do you want to go? |
Hi @luisramos0 , Thank you for your notes on the issue and in this PR. I verified that the PR makes hitting enter work, as an alternative to manually pressing the Filter Results button on:
Good to go, |
What? Why?
Closes #4437
It feels like too much copy paste for such a simple feature. I left the first commit so reviewers can see the alternative directive approach. The alternative approach was not working for the orders page, so I decided to go with ng-keypress.
On the orders page we only add the behavior to free text fields.
What should we test?
Products search /admin/products - type something on quick search and press enter, see the results being updated.
Orders search /admin/orders - type something on any of the text fields (Invoice number, email, first name and last name) and press enter, see results being updated
Release notes
Changelog Category: Added
Pressing enter will submit the search form on admin orders and products.