Enhancement/5454 make links to shops under Groups > Producers open in new tab #5601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeduardo824
changed the title
|
@tschumilas Requested changes! Please, do not merge! |
jeduardo824
force-pushed
the
enhancement/5454-links-to-shops-in-new-tabs
branch
from
c537677
to
573f7b1
Compare
jeduardo824
changed the title
|
Ready to go!! |
sauloperez
approved these changes
Jun 23, 2020
|
Hey @jeduardo824 , Nice! These links now open in separate tabs - Thank you for this improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #5454
What should we test?
If the shops' links are opening in a new tab properly (both producers name and shops when the tab expands).
Release notes
Make shops' links on groups page open in a new tab (both producer name and shops when the tab expands).
Changelog Category: Changed
Result:
