Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump paper_trail from 5.2.3 to 7.1.3 #5616

Merged
merged 1 commit into from Aug 15, 2020

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Jun 16, 2020

Bumps paper_trail from 5.2.3 to 7.1.3.

Release notes

Sourced from paper_trail's releases.

v7.0.0

No release notes provided.

v6.0.2

No release notes provided.

v6.0.1

No release notes provided.

6.0.0

See changelog

Changelog

Sourced from paper_trail's changelog.

7.1.3 (2017-09-19)

Breaking Changes

  • None

Added

  • None

Fixed

  • #988 - Fix ActiveRecord version check in VersionConcern for Rails 4.0

7.1.2 (2017-08-30)

Breaking Changes

  • None

Added

  • None

Fixed

  • #985 - Fix RecordInvalid error on nil item association when belongs_to_required_by_default is enabled.

7.1.1 (2017-08-18)

Breaking Changes

  • None

Added

  • None

Fixed

  • Stop including unnecessary files in released gem. Reduces .gem file size from 100K to 30K.
  • #984 - Fix NameError suspected to be caused by autoload race condition.

7.1.0 (2017-07-09)

Breaking Changes

... (truncated)
Commits
  • c0a90c2 Release 7.1.3
  • eb0b8a2 Merge pull request #992 from airblade/linting_20170918
  • df4f3bb Lint: Fix various offenses, mostly rspec
  • b2bf3dd Merge pull request #991 from airblade/rubocop50
  • 33c9285 rubocop 0.50.0 (was 0.48.1)
  • f6091c4 Merge pull request #989 from gurgelrenan/patch-1
  • 0b01b1b Fix broken link
  • c783109 Merge pull request #988 from magnusvk/fix-rails-4-0-version-check
  • 813b807 Fix changelog
  • 0c5b38a Add comment that this is only for Rails 4.0
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Copy link
Contributor

@luisramos0 luisramos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a big jump!
We need to verify that changes in enterprises, OCs and schedules are still saved in the versions table.
No functional manual test is required, only dev test.

@luisramos0 luisramos0 added the dev-test A dev need to test this one label Jun 16, 2020
@luisramos0 luisramos0 added the pr-staged-fr staging.coopcircuits.fr label Jul 7, 2020
@luisramos0
Copy link
Contributor

These are the events in versions before this PR:
image

We need to test these 3 events.

This is broken in staging FR (this PR) and also in staging ES (v3).
Very easy to reproduce:

  • create a schedule
  • edit OC and add that schedule to the OC
  • verify versions table did not register the change

I am moving to In Dev. I'll come back to this soon as it is a broken feature.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/bundler/paper_trail-7.1.3 branch from e41bb89 to 18cb0e0 Compare July 30, 2020 16:56
@Matt-Yorkley
Copy link
Contributor

Matt-Yorkley commented Aug 15, 2020

Whilst investigating #5743 I tested this gem update, and the logging was working. Or I should say: logging is currently a bit broken (in regards to schedules being associated with order cycles), but this update doesn't change the current broken behavior.

I think we can merge this.

@luisramos0
Copy link
Contributor

ok, I see, I agree, it doesnt make things worse 👍

@luisramos0 luisramos0 merged commit 9754d8d into master Aug 15, 2020
@luisramos0 luisramos0 deleted the dependabot/bundler/paper_trail-7.1.3 branch August 15, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked dependencies dev-test A dev need to test this one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants