New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump ransack from 1.2.3 to 1.8.10 #5630
Conversation
Bumps [ransack](https://github.com/activerecord-hackery/ransack) from 1.2.3 to 1.8.10. - [Release notes](https://github.com/activerecord-hackery/ransack/releases) - [Changelog](https://github.com/activerecord-hackery/ransack/blob/master/CHANGELOG.md) - [Commits](activerecord-hackery/ransack@v1.2.3...v1.8.10) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cant remember why I choose to upgrade to 1.2.3 only, probably because of the version used in spree or maybe just the first version that worked with rails 4.1 🙈
The build looks good so maybe we can just do this.
Same tests as in #5610
Hey @luisramos0 and @sauloperez, The build is green - staging in FR worked well. Did a brief check on the app, all looks good as before. |
Seems this is still in FR staging, re-adding the label in case you want to have an extra look. |
Thanks @luisramos0 - no worries! I will check it tomorrow during the (european) morning. Should you or anyone need the staging server in the meantime, please feel free to use it. |
Hi @luisramos0 , I had a second look at this, and manually tested the filters and queries on search pages in Products and Orders: Products
Orders
It all looks good, but I did run into this situation: It looks like the Clear Filters button does not remove the previous settings - this is a known bug #5592. But I think it can really lead to misleading search results, if one adds other options on top, and performs a search. Anyway, this is not introduced by ransack upgrade so -> ready to go! 👍 |
Bumps ransack from 1.2.3 to 1.8.10.
Release notes
Sourced from ransack's releases.
Changelog
Sourced from ransack's changelog.
Commits
08b5ab4
Merge pull request #1003 from gregmolnar/1-8-stablef28690f
release 1.8.107f2ba3b
set Active Record dependency to < 5.235da74c
remove 5.2 from travis21c1eed
release 1.8.9a5cd95a
lock Active Record compatibility at <= 5.1.11d1c64b
Merge pull request #922 from alpaca-tc/support-form-with0031c90
Merge pull request #927 from gregmolnar/polyamorousd0805ac
absorb polyamorous0fe5eac
Maintainer wantedDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labels
will set the current labels as the default for future PRs for this repo and language@dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language@dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language@dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and language@dependabot badge me
will comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard: