New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Sell page to use User Guide links from configuration #5636
Update Sell page to use User Guide links from configuration #5636
Conversation
Hello, |
Hey @fatihorhan, yes this is a known "flaky" spec and unrelated to your PR. |
Thank you @sigmundpetersen . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, thanks for your PR!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome and thanks for this meaningful contribution @fatihorhan 😍 !
Thanks for review and speedy approval. |
Hey @fatihorhan this will now be tested according to your testing notes in the PR description. Someone from our testing team will do this and if it passes it will then be merged and added to the next weekly release. If you install the Zenhub browser extension you can follow the issues/PRs along our pipeline from Dev Ready through In Dev, Code Review and Test 👍 You can read more about the process here https://github.com/openfoodfoundation/openfoodnetwork/wiki/Pipeline-development-process |
Hi @fatihorhan , I checked that changes set in the Configurations (/admin/contents/edit, as superadmin) take effect here on the /sell page, so the correct hyperlink on "Find out more in our user guide." can now be set. Moving to ready to go, |
What? Why?
We (OFN Turkey) translated the user guide to Turkish and changed the configuration to link to that page but Sell page still links to global user guide because it doesn't use the configuration.
https://github.com/openfoodfoundation/openfoodnetwork/blob/master/app/views/home/sell.html.haml has hard links for user guides but it should use the configuration like in https://github.com/openfoodfoundation/openfoodnetwork/blob/master/app/views/admin/shared/_user_guide_link.html.haml.
This PR fixes that.
What should we test?
Sell page link to the URL set in configuration.
Release notes
Sell page now uses configuration for user guide links.
Changelog Category: Fixed
Discourse thread
https://openfoodnetwork.slack.com/archives/C2GQ45KNU/p1592157142302400