Remove taxon icons #5713
Remove taxon icons #5713
Conversation
|
Agree but does the product team and the affected instance managers know about it? IMO this should be discussed in the production curation or delivery meeting. |
|
Can we have a screenshot of before and after to see what icons are being removed? |
|
@luisramos0 I believe they are only working for AU and UK currently. And maybe one day we will want to provide shops with entries by product category. So we won't use icons but images. |
|
My work removed the icon from the product listing (e1422e1). But this pull request is removing the whole feature including the upload of icons etc. I would like to know what the product team thinks about this, otherwise great initiative! |
These icons are inconsistently used across instances and have already been removed in a few places in the app in the mobile UX redesign.
|
Rebased. The build had some weird EnterpriseController errors... 馃憤 |
|
That's what broke the build and @luisramos0 fixed, I believe. |
| @@ -10,7 +10,6 @@ | |||
| .trans-sentence | |||
| %div | |||
| %span.fat-taxons{"ng-repeat" => "taxon in hub.taxons"} | |||
| %render-svg{path: "{{taxon.icon}}"} | |||
There was a problem hiding this comment.
this is removing the icons from the shops page, I think we need a screenshot with before/after so we can see the impact.
There was a problem hiding this comment.
yes, seeing we don't mess up with margins and padding would be good
There was a problem hiding this comment.
This PR vs Katuma prod:
Filters in /shops
Filters in shop page
No change, these icons are already missing on most servers.
|
ok, these icons on the top right will also go, correct? |
|
I think so @luisramos0 this is how it looks in Katuma
We could as well remove that |
|
The ribbon is already removed in the new product listing branch. |
|
Hi @Matt-Yorkley , This looks good,
Before this PR
After this PR
before this PR
after this PR
Checked Admin/Superadmin pages related to editing taxons: all works as before. Taxon errors 404 from .svg icons are gone after this PR - awesome @Matt-Yorkley ! Ready to go. |
What? Why?
These icons are inconsistently used across instances and have already started to be removed in a few places ( for example in the mobile UX redesign). They regularly trigger a long string of 404 responses in some servers, but it's not even consistent 馃檲
馃敟 馃敟
What should we test?
Taxon icons are not present in the /shops index page, or on the /shop page. Admin (superadmin?) pages related to editing taxons are working correctly (view, update, etc).
Release notes
Removed taxon icons