Bump wicked_pdf from 1.4.0 to 2.1.0 #5738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot-preview[bot]](https://avatars.githubusercontent.com/in/2141?s=60&v=4){kind=small}
Bumps [wicked_pdf](https://github.com/mileszs/wicked_pdf) from 1.4.0 to 2.1.0. - [Release notes](https://github.com/mileszs/wicked_pdf/releases) - [Changelog](https://github.com/mileszs/wicked_pdf/blob/master/CHANGELOG.md) - [Commits](mileszs/wicked_pdf@1.4.0...2.1.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
luisramos0
approved these changes
Jul 7, 2020
|
I think we should do some sanity checks for successful PDF creation. Moving to test ready... |
Matt-Yorkley
approved these changes
Jul 7, 2020
|
Hi @luisramos0 and @Matt-Yorkley , Tested pdf rendering in:
All works as before, this is ready to go. As a side note, and unrelated to this PR: error 422 is still observed in the console, for some orders when bulk-printing. This does not break the functionality (the pdf is rendered) and seems to appear mostly when printing orders which have a "due balance" status, but not always. The error does not occur if the pdf is printed via admin/orders/Rxxxxxxx/print.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps wicked_pdf from 1.4.0 to 2.1.0.
Changelog
Sourced from wicked_pdf's changelog.
Commits
309ef96Update VERSION to 2.1.0aefa10fAdd optionuse_xvfbto emulate an X server (#909)23c13d7Add a option to disable/enable local file access for wkhtmltopdf 0.12.63120646Merge pull request #915 from weber-s/master914a310add 'locals' option to the README advanced section3a3ccc0Merge pull request #905 from reinaris/patch-18e6f708Add no_stop_slow_scripts to readme0139342Merge pull request #896 from skillstream/master1efdba2Support webpacker assetsb019317Bump version for 2.0.2 releaseDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and language@dependabot badge mewill comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard: