New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make keyboard UI close on iOS when done searching #5747
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
the build is good, just flaky. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👌
This will need careful cross-browser testing on various devices 👍
Testing NotesTesting done:
Devices and results: ✅ iPhone SE (2020) - works correctly in Firefox / Safari / Chrome Also tested on a Nexus / Android 6.0.1 / Chrome 78 and it was still working as expected. @Matt-Yorkley when you said:
Does the list above suffice? If yes, then feel free to merge this. If not, then what else do you think it should be tested on? |
@mbudm what do you think, in the absence of a response from @Matt-Yorkley can you jump in and give an opinion of whether the testing I did on browsers/devices was sufficient to have this merged? |
tbh I landed here because I need the AUS staging server to test something... but now that I am here, I think I can help: we could go wild on browserstack but I think the testing done is sufficient for this small change. |
What? Why?
Closes #5434
Change to new directive that prevents enter default and blurs the input field. This closes the keyboard UI when the user selects the 'search' button (an alias for enter)
What should we test?
The search results are displayed (updated on each key press) and the keyboard is hidden
Release notes
Fixed hiding of keyboard when done searching products in a shop
Changelog Category: Changed