Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make keyboard UI close on iOS when done searching #5747

Merged
merged 1 commit into from Jul 24, 2020

Conversation

mbudm
Copy link

@mbudm mbudm commented Jul 8, 2020

What? Why?

Closes #5434

Change to new directive that prevents enter default and blurs the input field. This closes the keyboard UI when the user selects the 'search' button (an alias for enter)

What should we test?

  • navigate to a shop on an iOS device
  • click on the search field
  • enter a search string
  • click search (on the iOS keyboard)

The search results are displayed (updated on each key press) and the keyboard is hidden

Release notes

Fixed hiding of keyboard when done searching products in a shop

Changelog Category: Changed

@mbudm mbudm self-assigned this Jul 8, 2020
Copy link
Contributor

@luisramos0 luisramos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@luisramos0
Copy link
Contributor

the build is good, just flaky.

Copy link
Contributor

@Matt-Yorkley Matt-Yorkley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌

This will need careful cross-browser testing on various devices 👍

@daniellemoorhead daniellemoorhead self-assigned this Jul 17, 2020
@daniellemoorhead daniellemoorhead added the pr-staged-au staging.openfoodnetwork.org.au label Jul 17, 2020
@daniellemoorhead
Copy link
Contributor

daniellemoorhead commented Jul 17, 2020

Testing Notes

Testing done:

Devices and results:

✅ iPhone SE (2020) - works correctly in Firefox / Safari / Chrome
✅ iPad Mini 4 / Safari - works correctly in Firefox / Safari / Chrome
✅ iPhone 6s - works correctly in Firefox / Safari

Also tested on a Nexus / Android 6.0.1 / Chrome 78 and it was still working as expected.

@Matt-Yorkley when you said:

This will need careful cross-browser testing on various devices 👍

Does the list above suffice? If yes, then feel free to merge this. If not, then what else do you think it should be tested on?

@daniellemoorhead
Copy link
Contributor

@mbudm what do you think, in the absence of a response from @Matt-Yorkley can you jump in and give an opinion of whether the testing I did on browsers/devices was sufficient to have this merged?

@luisramos0
Copy link
Contributor

luisramos0 commented Jul 24, 2020

tbh I landed here because I need the AUS staging server to test something... :trollface:

but now that I am here, I think I can help: we could go wild on browserstack but I think the testing done is sufficient for this small change.
I am going to merge this. Well done 💪

@luisramos0 luisramos0 merged commit 32d45f6 into openfoodfoundation:master Jul 24, 2020
@luisramos0 luisramos0 removed feedback-needed pr-staged-au staging.openfoodnetwork.org.au labels Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mobile ux] On iOS keyboard does not shut after entering search term on shopfront and clicking 'return' button
4 participants