Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing translation key for shipping_method and new_order #5788

Merged
merged 2 commits into from Jul 30, 2020

Conversation

romale
Copy link
Contributor

@romale romale commented Jul 19, 2020

admin/orders

What? Why?

Closes #[the issue number this PR is related to]

image

image

What should we test?

Release notes

Changelog Category: Added | Changed | Deprecated | Removed | Fixed | Security

How is this related to the Spree upgrade?

Discourse thread

Dependencies

Documentation updates

@romale romale changed the title Missing translation key for shipping_method Missing translation key for shipping_method and new_order Jul 19, 2020
Copy link
Contributor

@luisramos0 luisramos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a description of the issue, maybe a screenshot showing what is the translation missing?

@romale
Copy link
Contributor Author

romale commented Jul 20, 2020

This needs a description of the issue, maybe a screenshot showing what is the translation missing?

Ok, added screenshots

Copy link
Contributor

@luisramos0 luisramos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! Thanks.

The new_order one is a bug from https://github.com/openfoodfoundation/openfoodnetwork/pull/5482/files

@filipefurtad0 filipefurtad0 self-assigned this Jul 30, 2020
@filipefurtad0 filipefurtad0 added pr-staged-uk staging.openfoodnetwork.org.uk and removed pr-staged-uk staging.openfoodnetwork.org.uk labels Jul 30, 2020
@filipefurtad0
Copy link
Contributor

Hi @romale ,

All good here, the respective pages render well:

image

image

Thank you for adding these! Ready to go.

@filipefurtad0 filipefurtad0 removed the pr-staged-uk staging.openfoodnetwork.org.uk label Jul 30, 2020
@luisramos0 luisramos0 merged commit 1400b36 into openfoodfoundation:master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants